New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial fix for #10028 #10030

Merged

Jarred-Sumner merged 3 commits into main from jarred/partial-fix

Apr 8, 2024

Collaborator

Jarred-Sumner commented Apr 6, 2024

What does this PR do?

This is a partial fix for #10028

We are getting EBUSY in the module resolver when opening lots of directories, and we were not correctly handling errors in the directory entry cache in these code paths before.

I suspect this code needs to be reworked for Windows to avoid keeping parent directory handles open for any longer than necessary. That would be the better fix.

How did you verify your code works?

We need a way to write tests that simulate system calls. This is really hard to test for right now.

Jarred-Sumner and others added 2 commits

April 6, 2024 13:07


          Partial fix for #10028

b9864cb


          [autofix.ci] apply automated fixes

d9a5242

Contributor

github-actions bot commented Apr 6, 2024 •

edited

Loading

❌ @Jarred-Sumner 4 files with test failures on bun-darwin-aarch64:

test/js/bun/http/serve.test.ts 14 failing
test/js/bun/spawn/spawn.test.ts 1 failing
test/js/node/http/node-http.test.ts 1 failing
test/js/node/http2/node-http2.test.js 1 failing

View test output

^{#06066b526f0550144265bfce518ecb7b98a8f5af}

Contributor

github-actions bot commented Apr 6, 2024 •

edited

Loading

❌ @Jarred-Sumner 3 files with test failures on linux-x64:

test/cli/install/bunx.test.ts SIGTERM
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing

View test output

^{#06066b526f0550144265bfce518ecb7b98a8f5af}

Contributor

github-actions bot commented Apr 6, 2024 •

edited

Loading

❌ @Jarred-Sumner 12 files with test failures on bun-windows-x86_64-haswell

test\cli\install\bunx.test.ts 1 failing
test\cli\install\registry\bun-install-registry.test.ts 12 failing
test\integration\next-pages\test\dev-server-ssr-100.test.ts 1 failing
test\integration\next-pages\test\dev-server.test.ts 1 failing
test\integration\next-pages\test\next-build.test.ts 1 failing
test\js\bun\shell\bunshell.test.ts 3 failing
test\js\bun\shell\commands\rm.test.ts 4 failing
test\js\bun\shell\leak.test.ts 2 failing
test\js\node\async_hooks\AsyncLocalStorage.test.ts STATUS_STACK_BUFFER_OVERRUN
test\js\node\child_process\child-process-exec.test.ts 1 failing
test\js\node\dns\node-dns.test.js 2 failing
test\js\web\workers\worker.test.ts 1 failing

View test output

^{#06066b526f0550144265bfce518ecb7b98a8f5af}

Contributor

github-actions bot commented Apr 6, 2024 •

edited

Loading

❌ @Jarred-Sumner 3 files with test failures on bun-darwin-x64:

test/cli/install/registry/bun-install-registry.test.ts 23 failing
test/js/node/http/node-http.test.ts 1 failing
test/js/web/fetch/fetch.tls.test.ts 1 failing

View test output

^{#06066b526f0550144265bfce518ecb7b98a8f5af}


          Merge branch 'main' into jarred/partial-fix

28d3855

Contributor

github-actions bot commented Apr 8, 2024

❌ @Jarred-Sumner 3 files with test failures on linux-x64-baseline:

test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/node/watch/fs.watchFile.test.ts 1 failing

View test output

^{#06066b526f0550144265bfce518ecb7b98a8f5af}

Jarred-Sumner merged commit 2615dc7 into main

26 of 31 checks passed

Jarred-Sumner deleted the jarred/partial-fix branch

April 8, 2024 14:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet